Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unnecessary check in setMonsterOutfit function #4633

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

EPuncker
Copy link
Contributor

@EPuncker EPuncker commented Mar 3, 2024

Pull Request Prelude

Changes Proposed

it was preventing items like costume bags to change player outfit because monster list was not illusionable but was allowed in this item, in other words this check is useless and only breaks functionality

credits to @omarcopires for bringing this up to my attention

Issues addressed:

it was preventing items like costume bags to change player outfit because monster list was not illusionable but was allowed in this item, in other words this check is useless and only breaks functionality
Copy link
Contributor

@MillhioreBT MillhioreBT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EPuncker EPuncker merged commit 244e28c into master Mar 14, 2024
5 checks passed
@EPuncker EPuncker deleted the EPuncker-patch-1 branch March 14, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants