Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mini Refactor inventory update #4667

Merged
merged 1 commit into from
May 3, 2024
Merged

mini Refactor inventory update #4667

merged 1 commit into from
May 3, 2024

Conversation

MillhioreBT
Copy link
Contributor

  • I have followed [proper The Forgotten Server code styling][code].
  • I have read and understood the [contribution guidelines][cont] before making this PR.
  • I am aware that this PR may be closed if the above-mentioned criteria are not fulfilled.

Changes Proposed

Moved the inventory update notification logic for the onEquip, onDeEquip and onInventoryUpdate events to separate methods, removed the notification in iologindata as it was never actually needed, it's just a matter of adding the call in the onCreatureAppear event

Issues addressed: Nothing!

@MillhioreBT MillhioreBT merged commit 24232dd into otland:master May 3, 2024
19 checks passed
@MillhioreBT MillhioreBT deleted the refactoring_update_inventory branch May 3, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EvilHero90 EvilHero90 EvilHero90 approved these changes

@ranisalt ranisalt Awaiting requested review from ranisalt

@EPuncker EPuncker Awaiting requested review from EPuncker

@nekiro nekiro Awaiting requested review from nekiro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MillhioreBT @EvilHero90