Fix possible crash

[kygov]

Pull Request Prelude

• I have followed proper The Forgotten Server code styling.
• I have read and understood the contribution guidelines before making this PR.
• I am aware that this PR may be closed if the above-mentioned criteria are not fulfilled.

Changes Proposed

Fixed broken iteration.

Issues addressed:
Crash because removing element from map and iterating.

[EvilHero90]

This doesn't work either as expected, I'd suggest to do it the safe way with 2 loops

std::vector<std::string> invalid;
for (auto& event : creatureEvents) {
	if (event.second.getScriptId() == 0) {
		invalid.push_back(event.first);
	}
}
for (auto& toRemove : invalid) {
	creatureEvents.erase(toRemove);
}
invalid.clear();

[kygov]

This doesn't work either as expected, I'd suggest to do it the safe way with 2 loops

std::vector<std::string> invalid;
for (auto& event : creatureEvents) {
	if (event.second.getScriptId() == 0) {
		invalid.push_back(event.first);
	}
}
for (auto& toRemove : invalid) {
	creatureEvents.erase(toRemove);
}
invalid.clear();

What's not working as expected?

[EvilHero90]

What's not working as expected?

tried it on different online debuggers, the first one I tried gave weird outcomes, others work just fine
sorry my mistake

[nekiro]

could be std::erase_if