Use Party shared_ptr instead of raw pointers #4687
Conversation
| @@ -564,8 +563,7 @@ ChatChannel* Chat::getChannel(const Player& player, uint16_t channelId) | |||
| } | |||
|
|
|||
| case CHANNEL_PARTY: { | |||
| Party* party = player.getParty(); | |||
| if (party) { | |||
| if (const auto& party = player.getParty()) { | |||
There was a problem hiding this comment.
It's been my experience that declaring a variable and checking it at same time inside the if statement causes crashes. I'm sure this isn't true in all cases, but I'm just stating what has been my experience so far.
There was a problem hiding this comment.
How so? It's equivalent other than the scoping (which would cause compilation errors, not crashes)
Would be interesting to see a form of reproduction though
There was a problem hiding this comment.
I have an example you can use to reproduce. I will contact you about it on discord.
EvilHero90
added
the
enhancement
| @@ -12,11 +12,11 @@ | |||
| extern Game g_game; | |||
| extern Events* g_events; | |||
|
|
|||
| Party::Party(Player* leader) : leader(leader) { leader->setParty(this); } | |||
| Party::Party(Player* leader) : leader(leader) { leader->setParty(shared_from_this()); } | |||
There was a problem hiding this comment.
shared_from_this() is not available in constructor, so this will throw exception
There was a problem hiding this comment.
Also, arguably setParty is responsibility of the function that creates the party.
There was a problem hiding this comment.
Also, there should be clear ownership which is now unknown, we could say its the leader who owns a party, but this may lead to crashes if leader is deleted ex on logout (this happens on disband with no members in party, look how leader party is set to nullptr which triggers delete on party pointer, which is later used). Imo this should follow the pattern and store every created party in game class, party class should have static factory method such as createParty (similar to createNpc) and members and leader should have a weak reference to the party.
Pull Request Prelude
Changes Proposed
autoandconst auto, at all, when possible.