Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow syntax fix introduced in #4721 #4723

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

EvilHero90
Copy link
Contributor

Pull Request Prelude

Changes Proposed

Fixes #4721 since it introduced syntax errors.

Issues addressed:

@EvilHero90 EvilHero90 changed the title Update build-vcpkg.yml Workflow syntax fix introduced in #4721 Jun 3, 2024
@EPuncker EPuncker requested a review from ranisalt June 3, 2024 03:11
@ranisalt
Copy link
Member

ranisalt commented Jun 3, 2024

Weird af

When you use expressions in an if conditional, you can, optionally, omit the ${{ }} expression syntax because GitHub Actions automatically evaluates the if conditional as an expression.

ref

Or was it the quoting?

@EvilHero90
Copy link
Contributor Author

Weird af

When you use expressions in an if conditional, you can, optionally, omit the ${{ }} expression syntax because GitHub Actions automatically evaluates the if conditional as an expression.

ref

Or was it the quoting?

Could probably be the case, I just sticked to what was the most common I've found

@EvilHero90 EvilHero90 merged commit 75cefe8 into otland:master Jun 3, 2024
15 checks passed
@EvilHero90 EvilHero90 deleted the workflow-fix branch June 3, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants