Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix npm package main script #15

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

MillerRen
Copy link

fix npm package main script in node.js require or import

fix npm package main script in node.js require or import
svg.path.js Outdated
// TODO: Solve
L: function(p) {
p = (arguments.length === 1) ? [p.x, p.y] : slice(arguments);

return this.addSegment('L', p, this._redrawEnabled);
},
l: function(p) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove the lower case functions? Like l, m, h and so on?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ignore that. cherrypick the right code :)

@mattkelly
Copy link
Contributor

This shouldn't be needed after #18 was merged. @otm I know you're super busy, but is it possible to publish a version with this fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants