Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResolverArgsの型推論が間違っている #39

Closed
SnO2WMaN opened this issue Dec 5, 2022 · 10 comments
Closed

ResolverArgsの型推論が間違っている #39

SnO2WMaN opened this issue Dec 5, 2022 · 10 comments

Comments

@SnO2WMaN
Copy link
Member

SnO2WMaN commented Dec 5, 2022

utils/types.tsResolverArgsが全然間違っているらしく,第一引数にTParentが来ることになっているが,実際には来ない(第一引数にやってくるのはTArgs

@SnO2WMaN
Copy link
Member Author

SnO2WMaN commented Dec 5, 2022

codegenの生成がそもそもおかしい

@SnO2WMaN
Copy link
Member Author

SnO2WMaN commented Dec 5, 2022

Video.hasTagが延々と嘘を返し続けている(inputが正しく取得できていないので)

@rokoucha
Copy link
Collaborator

rokoucha commented Dec 5, 2022

やっぱそうかー、codegen と graphql.js の型が当ってない可能性は codegen 入れる時にちょっと思ってたけど見なかった事にしてた

@rinsuki
Copy link
Collaborator

rinsuki commented Dec 5, 2022

@rokoucha
Copy link
Collaborator

rokoucha commented Dec 5, 2022

そんな気がしてる、graphql.js 対応とは一言も言ってないんだよね

@rinsuki
Copy link
Collaborator

rinsuki commented Dec 5, 2022

確かに第一引数にGraphQLの引数来そう https://graphql.org/graphql-js/object-types/

@rinsuki
Copy link
Collaborator

rinsuki commented Dec 5, 2022

customResolverFn で変更できるらしい

@rinsuki
Copy link
Collaborator

rinsuki commented Dec 5, 2022

いやこれやると合ってる直resolversのほうも変わっちゃうな

@SnO2WMaN
Copy link
Member Author

SnO2WMaN commented Dec 6, 2022

我々は全員間違えていて,すべき実装は以下だった.

{
  Query: {},
  Mutation: {},
  Video: {
    hasTag(parent,args,ctx,info) {
      console.dir(parent);
      return false;
    },
  },
};

@SnO2WMaN
Copy link
Member Author

SnO2WMaN commented Dec 7, 2022

多分もう解決しただろう #44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants