Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add upstream test suite with runner #2

Merged
merged 3 commits into from
Apr 14, 2021

Conversation

klette
Copy link
Member

@klette klette commented Apr 14, 2021

This will not pass for a while :-)

@klette klette force-pushed the klette/upstream-content-test-suite branch 2 times, most recently from 6d796b8 to fc69ec0 Compare April 14, 2021 13:26
@sourcery-ai
Copy link

sourcery-ai bot commented Apr 14, 2021

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.32%.

Quality metrics Before After Change
Complexity 5.30 ⭐ 5.30 ⭐ 0.00
Method Length 35.50 ⭐ 35.31 ⭐ -0.19 👍
Working memory 8.61 🙂 8.50 🙂 -0.11 👍
Quality 73.03% 🙂 73.35% 🙂 0.32% 👍
Other metrics Before After Change
Lines 156 156 0
Changed files Quality Before Quality After Quality Change
sanity_html/renderer.py 64.86% 🙂 64.86% 🙂 0.00%
tests/test_rendering.py 95.47% ⭐ 96.68% ⭐ 1.21% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
sanity_html/renderer.py SanityBlockRenderer._render_list 11 🙂 154 😞 15 😞 44.01% 😞 Try splitting into smaller methods. Extract out complex expressions
sanity_html/renderer.py SanityBlockRenderer._render_node 6 ⭐ 65 🙂 10 😞 68.19% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

@klette klette merged commit b927d0c into main Apr 14, 2021
@klette klette deleted the klette/upstream-content-test-suite branch April 14, 2021 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants