bugfix: fix a bug where custom serializer blocks can fail if after a … (Sourcery refactored) #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Make the 1.1.2 release
…list This commit fixes a bug where the rendering of a node can fail if it has fields not supported by Block and follows directly after a list item. The list item logic would pass in the first node after the list as context and cast it to a Block. This fails if the node has fields not supported by Block. Which is the case for custom serializer blocks. The context is actually not used, and removing it solves the bug.
Comment on lines
-211
to
+215
| parent = self._find_list(tree[-1], level=node.get('level'), list_item=node.get('listItem')) | ||
| if parent: | ||
| if parent := self._find_list( | ||
| tree[-1], | ||
| level=node.get('level'), | ||
| list_item=node.get('listItem'), | ||
| ): |
There was a problem hiding this comment.
Function PortableTextRenderer._normalize_list_tree refactored with the following changes:
- Use named expression to simplify assignment and conditional (
use-named-expression)
Comment on lines
-243
to
+246
| children = root_node.get('children') | ||
| if children: | ||
| if children := root_node.get('children'): |
There was a problem hiding this comment.
Function PortableTextRenderer._find_list refactored with the following changes:
- Use named expression to simplify assignment and conditional (
use-named-expression)
Sourcery Code Quality ReportMerging this PR leaves code quality unchanged.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
Kakebake
force-pushed
the
espenra/custom-serializer-after-list-bug
branch
from
e6949b0
to
69fa475
Compare
sourcery-ai
bot
deleted the
sourcery/espenra/custom-serializer-after-list-bug
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request #44 refactored by Sourcery.
If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
espenra/custom-serializer-after-list-bugbranch, then run:Help us improve this pull request!