Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop recording merge page support #7

Merged
merged 1 commit into from Nov 9, 2023
Merged

Drop recording merge page support #7

merged 1 commit into from Nov 9, 2023

Conversation

jesus2099
Copy link
Contributor

@jesus2099 jesus2099 commented Oct 15, 2023

... as it is now part of MBS:
https://tickets.metabrainz.org/browse/MBS-2768
metabrainz/musicbrainz-server#1586

If we keep this code, we have a duplicate AcoustID column.

@otringal
Copy link
Owner

otringal commented Nov 9, 2023

Hi! Sorry for the late reply, I've been busy the last few weeks with various things and didn't have time to look into this. Thanks for the ping though, I was going to look into this last weekend but forgot. The reason why I didn't remove it myself is because I remember that the script stopped working on that page after the update that you mentioned, but something must have changed because now it works again (I guess that's why you noticed it). I think we both can agree that he official solution looks much worse than mine. I had some ideas to update my script so that it instead makes MB's own AcoustID list collapsible and perhaps also removes the AcoustIDs that has "line-through" from the visible list. But that requires new code so no harm in removing it completely from that page for now.

Thanks for fixing!

@otringal otringal merged commit ad8bea3 into otringal:master Nov 9, 2023
@jesus2099
Copy link
Contributor Author

the official solution looks much worse

Oh I don't remember.
I've been seeing that duplicate column for a quote long time but thought they were really identical.
I'll try again and compare.
Now we can make PR on MBS to improve it! 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants