Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check and include more values to Phi #58

Closed
3 of 4 tasks
claucece opened this issue Mar 18, 2018 · 5 comments
Closed
3 of 4 tasks

Check and include more values to Phi #58

claucece opened this issue Mar 18, 2018 · 5 comments
Assignees
Labels
discuss importance high An issue that is absolutely necessary to have done before final release OTRv4 basics

Comments

@claucece
Copy link
Member

claucece commented Mar 18, 2018

Why

As we are currently implementing the revision number 2 of the OTRv4 specification, we need to include a more values to the phi value .

Reference

Please, refer to the "Shared Session State" section of the OTRv4 specification.

Tasks

  • Include to the phi value the session identifier mandated by the OTRv4 spec.
  • Concatenate this prior value to a value set up by the client.
  • Check if one part of the phi value is coming correctly from the client.
  • Consider for how long should the phi value live before been deleted.

Open questions

For how long should the phi value live?

@olabini
Copy link
Contributor

olabini commented Apr 9, 2018

This seems to slightly overlap with #47

@claucece
Copy link
Member Author

claucece commented Apr 9, 2018

@olabini #47 is more about replacing dummy values introduced and actually taken functionality from client (phi and the shared prekey), whereas this issue is about defining phi.

@olabini
Copy link
Contributor

olabini commented Apr 9, 2018

Ah, OK. That's why I said "slightly" only... =)

@deniscostadsc
Copy link
Contributor

I read the "Shared Session State" section, but still not clear where do this. is it here?

@claucece
Copy link
Member Author

claucece commented Jun 5, 2018

We can talk tomorrow. I have free time at 12pm, does that work for you? @deniscostadsc

@deniscostadsc deniscostadsc self-assigned this Jun 5, 2018
claucece added a commit that referenced this issue Jun 7, 2018
@juniorz juniorz moved this from To Do to In Progress in Full OTRv4 flow #2 Jun 7, 2018
@claucece claucece added the importance high An issue that is absolutely necessary to have done before final release label Jun 8, 2018
claucece added a commit that referenced this issue Jun 15, 2018
deniscostadsc added a commit that referenced this issue Jun 18, 2018
deniscostadsc added a commit that referenced this issue Jun 18, 2018
deniscostadsc added a commit that referenced this issue Jun 19, 2018
deniscostadsc added a commit that referenced this issue Jun 20, 2018
deniscostadsc added a commit that referenced this issue Jun 20, 2018
@deniscostadsc deniscostadsc moved this from In Progress to Q/A in Full OTRv4 flow #2 Jun 20, 2018
@claucece claucece moved this from Q/A to Done in LibOTR-ng API Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss importance high An issue that is absolutely necessary to have done before final release OTRv4 basics
Projects
No open projects
Development

No branches or pull requests

3 participants