Skip to content
This repository has been archived by the owner on Dec 4, 2018. It is now read-only.

Update deps for Sailfish OS 2.0.5 #29

Merged
merged 3 commits into from
Nov 26, 2016
Merged

Update deps for Sailfish OS 2.0.5 #29

merged 3 commits into from
Nov 26, 2016

Conversation

ilpianista
Copy link
Contributor

qt5-plugin-geoservices-nokia has been renamed as qt5-plugin-geoservices-here.

@otsaloma
Copy link
Owner

I haven't installed 2.0.5 yet, so I can't test. Did you test that your fix works? Is it really just the package name changed, not the API -- e.g. the plugin name?

`qt5-plugin-geoservices-nokia` has been renamed as `qt5-plugin-geoservices-here`.
@ilpianista
Copy link
Contributor Author

Nope, I didn't test it. I thought it was only the package name that is changed.

I'll try test it this evening.

@otsaloma
Copy link
Owner

It's hard to tell from the version number, but it's likely that they have backported the API changes of the HERE plugin, which would mean the name "here" and "here." prefixes on the parameter names.

http://doc.qt.io/qt-5/location-plugin-here.html#parameters

I'll probably upgrade and test on the weekend.

@otsaloma
Copy link
Owner

There was a small API change: app_code instead of token. With that change it works. Merging.

@otsaloma otsaloma merged commit a7da395 into otsaloma:master Nov 26, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants