New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Meta OT Initializer #145
Meta OT Initializer #145
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Brandon!! this looks fantastic as an addition!! a few minor comments + suggestion to use ent_reg_cost
directly (open question would be to handle tau_...
with MetaOT... Maybe for now set to 1...)
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #145 +/- ##
==========================================
+ Coverage 89.80% 89.84% +0.04%
==========================================
Files 51 51
Lines 4971 5040 +69
Branches 505 509 +4
==========================================
+ Hits 4464 4528 +64
- Misses 386 389 +3
- Partials 121 123 +2
|
@marcocuturi - Thanks, I just pulled the latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good for me!! @michalk8 want to take a look?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @bamos , I have made a few comments, will look at the notebook later!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bamos , just minor changes needed.
+ Move to ott/core/initializers + Plot MNIST images and interpolations in nb + Add test and docs
I've updated the name to |
There's no need to do this on your side, we do by default squash merges on PRs. LGTM, thanks @bamos, I think this is a great addition! |
Thanks for the help and for going through everything so thoroughly! :-) |
This is an initial version of a Meta OT initializer along with a notebook demonstrating it's usage.
Here is how the notebook renders in the website, and here are how the code docs render: