New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misnumbered equation #513

Closed

gjhuizing opened this issue Apr 4, 2024 · 1 comment

Contributor

gjhuizing commented Apr 4, 2024

Hi!

This is a tiny detail, but it seems the preprint was updated and that equation 24 has changed.

ott/src/ott/solvers/linear/sinkhorn.py

Line 278 in e1bbd34

# Using https://arxiv.org/pdf/1910.12958.pdf (24)

https://arxiv.org/pdf/1910.12958v2.pdf has the right equation though.

While I'm at it, in the Sinkhorn docs, https://ott-jax.readthedocs.io/en/latest/solvers/_autosummary/ott.solvers.linear.sinkhorn.Sinkhorn.html, shouldn't it be +g in eq 1, and +KL in eq 3?

Best

GJ

pkassraie mentioned this issue

Fixing typos in documentation #548

Merged

Collaborator

michalk8 commented Jun 6, 2024

Thanks @gjhuizing for noticing this, closed via #548

michalk8 closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment