Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix point_clouds.ipynb #159

Merged
merged 2 commits into from
Oct 20, 2022
Merged

fix point_clouds.ipynb #159

merged 2 commits into from
Oct 20, 2022

Conversation

marcocuturi
Copy link
Contributor

New tutorial for point_clouds,

  • simplified with less calls to soon to be deprecated APIs, and more reliance on the geometry, LinearProblem and Sinkhorn solver classes.
  • simplified "optimize" loop, 1 call to Sinkhorn instead of 2 previously.
  • more examples of gradient flows.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov-commenter
Copy link

Codecov Report

Merging #159 (e6524b3) into main (8646692) will decrease coverage by 5.86%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #159      +/-   ##
==========================================
- Coverage   89.83%   83.97%   -5.87%     
==========================================
  Files          51       51              
  Lines        5068     5068              
  Branches      519      519              
==========================================
- Hits         4553     4256     -297     
- Misses        391      660     +269     
- Partials      124      152      +28     
Impacted Files Coverage Δ
ott/core/discrete_barycenter.py 15.58% <0.00%> (-70.13%) ⬇️
ott/tools/segment_sinkhorn.py 43.75% <0.00%> (-56.25%) ⬇️
ott/tools/sinkhorn_divergence.py 61.81% <0.00%> (-32.73%) ⬇️
ott/tools/soft_sort.py 69.90% <0.00%> (-25.25%) ⬇️
ott/core/segment.py 75.00% <0.00%> (-25.00%) ⬇️
ott/core/gw_barycenter.py 74.50% <0.00%> (-22.55%) ⬇️
ott/geometry/pointcloud.py 68.62% <0.00%> (-14.96%) ⬇️
ott/geometry/graph.py 81.69% <0.00%> (-12.68%) ⬇️
ott/core/bar_problems.py 74.57% <0.00%> (-9.61%) ⬇️
...tt/tools/gaussian_mixture/gaussian_mixture_pair.py 85.33% <0.00%> (-6.67%) ⬇️
... and 20 more

@marcocuturi
Copy link
Contributor Author

failed test seems to come from bug in CI.

@marcocuturi marcocuturi merged commit 93abcc9 into main Oct 20, 2022
@marcocuturi marcocuturi deleted the marco-main branch October 22, 2022 08:05
michalk8 pushed a commit that referenced this pull request Jun 27, 2024
* fix point_clouds.ipynb

* fix linter for nb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants