Remove functional API #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #222 +/- ##
==========================================
- Coverage 89.21% 80.46% -8.76%
==========================================
Files 52 52
Lines 5315 5299 -16
Branches 549 542 -7
==========================================
- Hits 4742 4264 -478
- Misses 438 886 +448
- Partials 135 149 +14
|
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Merged
marcocuturi
approved these changes
Jan 5, 2023
tests/helpers/test_utils.py
Outdated
| from ott.solvers.linear import sinkhorn | ||
|
|
||
|
|
||
| def run_sinkhorn( |
There was a problem hiding this comment.
this feels copy pasted from sinkhorn_divergence.
is there a place this could be stored that's more visible? or maybe stored in sinkhorn.py?
There was a problem hiding this comment.
Added as sinkhorn.solve + this function now also supports rank, to make it consistent with gromov_wasserstein.solve.
michalk8
added
deprecation
documentation
marcocuturi
approved these changes
Jan 6, 2023
michalk8
added a commit
that referenced
this pull request
Jun 27, 2024
* Remove `sinkhorn function` * Fix `sinkhorn_divergence` test * Remove `gromov_wasserstein` function * Remove `make` functions * Fix `soft_sort` and Jacobian tests * Remove `Transport` interface * Fix Jacobian test * Fix `soft_sort` and tests * Clean up some tests * Fix wrong `value_and_grad` usage * Update notebooks, isort and pre-commit * [ci skip] Fix rendering in `Sinkhorn` * Handle TODOs, clean initializer tests * Add `sinkhorn.solve` utility * Re-add `gromov_wasserstein.solve`, polish docs * Remove redundant line from `pyproject.toml` * Polish quad docs * Add rank to `sinkhorn.solve` * Add `rank` to `sinkhorn.solve`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
makefunctionsott.tools.transportinterface (was used sparsely); should be re-introduced in the future when creating abstraction for solver outputssinkhorn.sinkhorn -> sinkhorn.solvegromov_wasserstein.gromov_wasserstein -> gromov_wasserstein.solveisort(also enabled for notebooks)TODOs: