Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typos #339

Merged
merged 2 commits into from
Mar 22, 2023
Merged

typos #339

merged 2 commits into from
Mar 22, 2023

Conversation

marcocuturi
Copy link
Contributor

fixing some typos in soft-sort NB

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@michalk8 michalk8 self-requested a review March 21, 2023 17:29
@review-notebook-app
Copy link

review-notebook-app bot commented Mar 21, 2023

View / edit / reply to this conversation on ReviewNB

michalk8 commented on 2023-03-21T17:46:03Z
----------------------------------------------------------------

Few small typos:

This notebooks shows how ott provides...

... true values, but will instead have more informative gradients.


marcocuturi commented on 2023-03-22T07:59:31Z
----------------------------------------------------------------

thanks!

Copy link
Collaborator

@michalk8 michalk8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small typos in the notebook, can be merged after. RTD fails because of their venv issues.

Copy link
Contributor Author

thanks!


View entire conversation on ReviewNB

@marcocuturi marcocuturi merged commit c745a2e into main Mar 22, 2023
@marcocuturi marcocuturi deleted the m4_ott branch March 22, 2023 08:03
michalk8 pushed a commit that referenced this pull request Jun 27, 2024
* typos

* typos
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants