Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add relative_epsilon option to GromovWasserstein #355

Merged
merged 3 commits into from
Jul 15, 2023

Conversation

michalk8
Copy link
Collaborator

@michalk8 michalk8 commented Apr 24, 2023

Also remove unscale_last_linearization.

TODOs:

  • tests

@michalk8 michalk8 added the enhancement New feature or request label Apr 24, 2023
@michalk8 michalk8 self-assigned this Apr 24, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 24, 2023

Codecov Report

Merging #355 (865b93f) into main (73e2b31) will increase coverage by 3.08%.
The diff coverage is 76.92%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #355      +/-   ##
==========================================
+ Coverage   88.28%   91.36%   +3.08%     
==========================================
  Files          51       55       +4     
  Lines        5513     5894     +381     
  Branches      828      853      +25     
==========================================
+ Hits         4867     5385     +518     
+ Misses        527      375     -152     
- Partials      119      134      +15     
Impacted Files Coverage Δ
src/ott/solvers/linear/sinkhorn.py 97.53% <ø> (+0.68%) ⬆️
src/ott/solvers/quadratic/gromov_wasserstein.py 87.50% <71.42%> (-1.39%) ⬇️
src/ott/problems/quadratic/quadratic_problem.py 89.07% <77.77%> (+2.47%) ⬆️
src/ott/initializers/quadratic/initializers.py 86.88% <100.00%> (ø)

... and 22 files with indirect coverage changes

Copy link
Contributor

@marcocuturi marcocuturi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcocuturi marcocuturi merged commit e04f016 into ott-jax:main Jul 15, 2023
11 checks passed
michalk8 added a commit that referenced this pull request Jun 27, 2024
* Add `relative_epsilon` option to `GromovWasserstein`

* Add test for relative epsilon

* Update initializers.py

---------

Co-authored-by: Marco Cuturi <marcocuturicameto@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants