Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test Plot class in tools module to increase coverage #394

Merged
merged 4 commits into from
Jul 12, 2023
Merged

Conversation

marcocuturi
Copy link
Contributor

also fix a minor bug where data was not converted to numpy before running svds

@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2023

Codecov Report

Merging #394 (83ebc8f) into main (1886edf) will increase coverage by 1.33%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #394      +/-   ##
==========================================
+ Coverage   89.92%   91.26%   +1.33%     
==========================================
  Files          55       55              
  Lines        5916     5896      -20     
  Branches      859      855       -4     
==========================================
+ Hits         5320     5381      +61     
+ Misses        470      379      -91     
- Partials      126      136      +10     
Impacted Files Coverage Δ
src/ott/tools/plot.py 76.85% <100.00%> (+59.66%) ⬆️
src/ott/utils.py 68.29% <100.00%> (ø)

@marcocuturi marcocuturi changed the title test plot tool to increase coverage test Plot class in tools module to increase coverage Jul 12, 2023
@marcocuturi marcocuturi merged commit 68f9d08 into main Jul 12, 2023
10 checks passed
@marcocuturi marcocuturi deleted the plot_tools branch July 13, 2023 17:09
michalk8 pushed a commit that referenced this pull request Jun 27, 2024
* test plot tool to increase coverage

* drop deprecated jnp.DeviceArray

* remove unused barycenters functions

* minor fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants