Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix not being able to jit the soft quantile #408

Merged
merged 2 commits into from
Aug 1, 2023
Merged

Fix not being able to jit the soft quantile #408

merged 2 commits into from
Aug 1, 2023

Conversation

michalk8
Copy link
Collaborator

@michalk8 michalk8 commented Aug 1, 2023

closes #407

@michalk8 michalk8 self-assigned this Aug 1, 2023
@michalk8 michalk8 mentioned this pull request Aug 1, 2023
Closed
marcocuturi
marcocuturi approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@marcocuturi marcocuturi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Michal!

@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #408 (338202c) into main (091e6f4) will decrease coverage by 0.74%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #408      +/-   ##
==========================================
- Coverage   91.32%   90.59%   -0.74%     
==========================================
  Files          55       55              
  Lines        5902     5901       -1     
  Branches      857      589     -268     
==========================================
- Hits         5390     5346      -44     
- Misses        376      414      +38     
- Partials      136      141       +5
Files Changed Coverage Δ
src/ott/tools/soft_sort.py 95.55% <100.00%> (ø)

... and 3 files with indirect coverage changes

@michalk8 michalk8 merged commit 28a2bf8 into ott-jax:main Aug 1, 2023
1 check was pending
@michalk8 michalk8 deleted the fix/jit-quantile branch August 1, 2023 20:19
michalk8 added a commit that referenced this pull request Jun 27, 2024
@michalk8
Fix not being able to jit the soft quantile (#408)
d0771bc 
* Fix not being able to jit the soft quantile

* [ci skip] Fix type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcocuturi marcocuturi marcocuturi approved these changes

Assignees

@michalk8 michalk8

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cant jit the function using soft_sort.quantile() and jnp.where()
2 participants
@michalk8 @marcocuturi