Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sparse Chebyshev approximation #502

Merged
merged 15 commits into from
Mar 18, 2024
Merged

Add sparse Chebyshev approximation #502

merged 15 commits into from
Mar 18, 2024

Conversation

guillaumehu
Copy link
Collaborator

@guillaumehu guillaumehu commented Mar 16, 2024

In this PR, we modify the Chebyshev approximation used in the geodesic geometry to work with sparse BCOO graph. This PR would close #476.

  • Sparse Laplacian fn
  • Sparse Cheb approximation fn
  • test heat kernel approx
  • test that it integrates with Sinkhorn.

Questions
Do we want to test that it is faster for sparse matrices ? We added a test for the memory usage.

Copy link

codecov bot commented Mar 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.61%. Comparing base (da704fc) to head (e9bc344).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #502      +/-   ##
==========================================
+ Coverage   90.59%   90.61%   +0.02%     
==========================================
  Files          60       60              
  Lines        6688     6703      +15     
  Branches      956      958       +2     
==========================================
+ Hits         6059     6074      +15     
  Misses        480      480              
  Partials      149      149              
Files Coverage Δ
src/ott/geometry/geodesic.py 93.33% <100.00%> (+1.11%) ⬆️

@guillaumehu guillaumehu marked this pull request as ready for review March 17, 2024 17:09
@michalk8 michalk8 self-requested a review March 17, 2024 17:36
src/ott/geometry/geodesic.py Outdated Show resolved Hide resolved
src/ott/geometry/geodesic.py Outdated Show resolved Hide resolved
src/ott/geometry/geodesic.py Outdated Show resolved Hide resolved
src/ott/geometry/geodesic.py Outdated Show resolved Hide resolved
src/ott/geometry/geodesic.py Outdated Show resolved Hide resolved
src/ott/geometry/geodesic.py Outdated Show resolved Hide resolved
src/ott/geometry/geodesic.py Outdated Show resolved Hide resolved
tests/geometry/geodesic_test.py Outdated Show resolved Hide resolved
tests/geometry/geodesic_test.py Show resolved Hide resolved
src/ott/geometry/geodesic.py Outdated Show resolved Hide resolved
@guillaumehu
Copy link
Collaborator Author

Thank you for reviewing the PR @michalk8 ! I made the suggested changes, let me know what you think.

Copy link
Collaborator

@michalk8 michalk8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @guillaumehu , LGTM!

@michalk8 michalk8 merged commit 51a658a into ott-jax:main Mar 18, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for sparse matrices in Geodesic geometry
2 participants