Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update One_Sinkhorn.ipynb #515

Merged
merged 1 commit into from
Apr 8, 2024
Merged

Update One_Sinkhorn.ipynb #515

merged 1 commit into from
Apr 8, 2024

Conversation

pkassraie
Copy link
Contributor

I think the description for calculating the default epsilon in this tutorial is inaccurate. The tutorial says that the algorithm sets the default $epsilon$ as "the mean distance described in the geometry".
However, looking into the code it seems to me that you're calculating the average of the cost matrix instead. For $\ell_2$ loss, this is twice the distance squared. For more complicated losses, this does not even have to be measure of distance.
I suggest we change this loss to "the mean cost described in the geometry" to avoid confusion.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@michalk8
Copy link
Collaborator

michalk8 commented Apr 8, 2024

Thanks, LGTM! Also seems like 1 test is failing, for unrelated reason. Will fix in a separate PR.

@michalk8 michalk8 merged commit 4bba69f into ott-jax:main Apr 8, 2024
8 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants