Fix/batched non sym cost #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Algue-Rythme
approved these changes
Apr 11, 2024
| @@ -199,51 +198,39 @@ def apply_lse_kernel( # noqa: D102 | |||
|
|
|||
| def body0(carry, i: int): | |||
| f, g, eps, vec = carry | |||
| y = jax.lax.dynamic_slice( | |||
| self.y, (i * self.batch_size, 0), (self.batch_size, self.y.shape[1]) | |||
| y, g_ = self._leading_slice(self.y, i), self._leading_slice(g, i) | |||
There was a problem hiding this comment.
I realise it might be worth using jax.lax.dynamic_slice_in_dim instead of jax.lax.dynamic_slice in self._leading_slice implem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes wrong computation for non-symmetric costs. This bug was only present when
batch_sizewas passed in thePointCloud.