Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force ICNN to adopt default initialization of its own layers #551

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

Algue-Rythme
Copy link
Collaborator

The ICNN used to rely on initialisation with normal matrices. Now, it fallbacks to the behavior of the layers, i.e lecun_normal, which scales the standard deviation of the weights with 1/sqrt(fan_in). This std is much smaller for wide networks.

Copy link

codecov bot commented Jun 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.39%. Comparing base (787d4a9) to head (27c582a).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #551      +/-   ##
==========================================
+ Coverage   91.38%   91.39%   +0.01%     
==========================================
  Files          69       69              
  Lines        7242     7242              
  Branches     1019     1018       -1     
==========================================
+ Hits         6618     6619       +1     
  Misses        472      472              
+ Partials      152      151       -1     
Files Coverage Δ
src/ott/neural/networks/icnn.py 94.54% <100.00%> (ø)

... and 1 file with indirect coverage changes

@michalk8 michalk8 self-requested a review June 25, 2024 09:26
Copy link
Collaborator

@michalk8 michalk8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Algue-Rythme , LGTM !

@michalk8 michalk8 merged commit d3b6c40 into main Jun 25, 2024
13 checks passed
@michalk8 michalk8 deleted the fixdefaultinit branch June 25, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants