TI transport map #559
Merged
TI transport map #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalk8
force-pushed
the
feature/gt-transport-fn
branch
from
2c108b1
to
66e1767
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #559 +/- ##
=======================================
Coverage 89.38% 89.39%
=======================================
Files 71 71
Lines 7545 7552 +7
Branches 1075 1075
=======================================
+ Hits 6744 6751 +7
Misses 650 650
Partials 151 151
|
marcocuturi
reviewed
Jul 11, 2024
tests/geometry/costs_test.py
Outdated
|
|
||
| np.testing.assert_array_equal(jnp.isfinite(h_transform(x)), True) | ||
| transport_fn = cost_fn.transport_map(lambda z: -jnp.sum(z * (A.dot(z)))) | ||
| transport_fn = jax.jit(transport_fn, static_argnames=["forward"]) |
There was a problem hiding this comment.
i think a good test would be to transport samples, on xs. get ys, keep them in that order, and then run the Hungarian algorithm and make sure the optimal permutation with cost h is identity (could use scipy's https://docs.scipy.org/doc/scipy/reference/generated/scipy.optimize.linear_sum_assignment.html)
There was a problem hiding this comment.
Done, works only with the exception of SqPNorm(1.0), changed to SqPNorm(1.05).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.