Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Grid.prepare_divergences #563

Merged
merged 2 commits into from
Jul 22, 2024
Merged

Fix Grid.prepare_divergences #563

merged 2 commits into from
Jul 22, 2024

Conversation

michalk8
Copy link
Collaborator

TODOs:

  • tests

closes #562

@michalk8 michalk8 added the bug Something isn't working label Jul 16, 2024
@michalk8 michalk8 self-assigned this Jul 16, 2024
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.41%. Comparing base (c941933) to head (eeae0a7).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #563      +/-   ##
==========================================
+ Coverage   89.39%   89.41%   +0.02%     
==========================================
  Files          71       71              
  Lines        7552     7550       -2     
  Branches     1075     1075              
==========================================
  Hits         6751     6751              
+ Misses        650      648       -2     
  Partials      151      151              
Files Coverage Δ
src/ott/geometry/grid.py 92.96% <0.00%> (+1.43%) ⬆️

@michalk8 michalk8 merged commit 2b866d3 into main Jul 22, 2024
9 of 11 checks passed
@michalk8 michalk8 deleted the fix/sd-grid branch July 22, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sinkhorn_divergence does not handle Grid geometry
1 participant