Skip to content

Commit

Permalink
Fix anonymize function and add tests (#177)
Browse files Browse the repository at this point in the history
  • Loading branch information
omris94 committed May 8, 2023
1 parent 1809d73 commit 226e535
Show file tree
Hide file tree
Showing 2 changed files with 50 additions and 4 deletions.
9 changes: 5 additions & 4 deletions src/shared/telemetries/telemetrysender/anonimize.go
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
package telemetrysender

import "crypto/sha256"
import (
"crypto/sha256"
"fmt"
)

const salt = "jTfYPbjfq9VlhTDfV9lZEyBI29QYqPqn"

func Anonymize(str string) string {
hasher := sha256.New()
hashBytes := hasher.Sum([]byte(salt + str))
return string(hashBytes)
return fmt.Sprintf("%x", sha256.Sum256([]byte(salt+str)))
}
45 changes: 45 additions & 0 deletions src/shared/telemetries/telemetrysender/anonymize_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
package telemetrysender

import (
"crypto/sha256"
"fmt"
"github.com/stretchr/testify/suite"
"testing"
)

type TelemetrySenderTestSuite struct {
suite.Suite
}

func (t *TelemetrySenderTestSuite) TestAnonymizeNotContainsOriginalStr() {
someStr := "This is a test string"
hash := Anonymize(someStr)
t.Require().NotContains(someStr, hash)
t.Require().NotContains(hash, someStr)
}

func (t *TelemetrySenderTestSuite) TestAnonymizeDeterministic() {
someStr := "This is a test string"
hash := Anonymize(someStr)
hash2 := Anonymize(someStr)
t.Require().Equal(hash, hash2)
}

func (t *TelemetrySenderTestSuite) TestAnonymizeDifferentForDifferentInputs() {
someStr := "This is a test string"
someStr2 := "This is a completely different test string"
hash := Anonymize(someStr)
hash2 := Anonymize(someStr2)
t.Require().NotEqual(hash, hash2)
}

func (t *TelemetrySenderTestSuite) TestAnonymizeSalted() {
someStr := "This is a test string"
hash := Anonymize(someStr)
hash2 := fmt.Sprintf("%x", sha256.Sum256([]byte(someStr)))
t.Require().NotEqual(hash, hash2)
}

func TestTelemetrySenderTestSuite(t *testing.T) {
suite.Run(t, &TelemetrySenderTestSuite{})
}

0 comments on commit 226e535

Please sign in to comment.