Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where pod-watcher would fail to reconcile pods due to missing schema registration #185

Merged
merged 14 commits into from
May 22, 2023

Conversation

orishoshan
Copy link
Collaborator

Pod watcher, which is responsible for labeling pods when they change, failed to reconcile pods because it required the v1.CustomResourceDefinition resource to be registered in its schema and it was not.

Added e2e test to catch this problem.

@orishoshan orishoshan requested a review from omris94 May 22, 2023 08:13
@orishoshan orishoshan enabled auto-merge (squash) May 22, 2023 08:13
@orishoshan orishoshan merged commit 8f770a4 into main May 22, 2023
8 checks passed
@orishoshan orishoshan deleted the orisho/fix_watcher branch May 22, 2023 08:24
@github-actions github-actions bot locked and limited conversation to collaborators May 22, 2023
@orishoshan orishoshan restored the orisho/fix_watcher branch May 22, 2023 09:37
@orishoshan orishoshan deleted the orisho/fix_watcher branch May 22, 2023 09:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants