Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Prometheus metrics and stop labeling namespaces if not necessary #302

Merged
merged 3 commits into from
Dec 4, 2023
Merged

Add Prometheus metrics and stop labeling namespaces if not necessary #302

merged 3 commits into from
Dec 4, 2023

Conversation

orishoshan
Copy link
Collaborator

@orishoshan orishoshan commented Dec 3, 2023 •
edited
Loading

Description

This PR:

  1. Adds Prometheus metrics.
  2. No longer uses the custom Otterize label for namespaces, instead preferring kubernetes.io/metadata.name where possible.

References

Closes #251.

Testing

Covered by existing tests.

Checklist

  • I have added documentation for new/changed functionality in this PR and in github.com/otterize/docs

@orishoshan orishoshan mentioned this pull request Dec 3, 2023
Merged
1 task
@orishoshan orishoshan merged commit ec9cee6 into main Dec 4, 2023
9 checks passed
@orishoshan orishoshan deleted the orisho/prometheus_metrics_and_netpols branch December 4, 2023 08:24
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@omris94 omris94 omris94 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Prometheus metrics
2 participants
@orishoshan @omris94