Introduce a new type: serviceEffectivePolicy as a better abstraction than ClientIntents for reconciliation. Implement EffectivePolicyReconciler for ingress network policies.
#323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omris94
changed the title
serviceEffectivePolicy as a better abstraction than ClientIntents for reconciliation. Implement EffectivePolicyApplier for ingress network policies.
orishoshan
reviewed
Jan 3, 2024
omris94
changed the title
serviceEffectivePolicy as a better abstraction than ClientIntents for reconciliation. Implement EffectivePolicyApplier for ingress network policies.serviceEffectivePolicy as a better abstraction than ClientIntents for reconciliation. Implement EffectivePolicyReconciler for ingress network policies.
orishoshan
approved these changes
Jan 8, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces two new abstractions:
ServiceEffectivePolicyandServerEffectivePolicyGroupReconciler. These abstractions are designed to help reconcile input resources (such as intents, pods, and protected services) to output policies (such as network policies for Ingress, Kafka ACLs, and Postgres).The
ServiceEffectivePolicytype is created, and anEffectivePolicyReconcileris implemented specifically for Ingress network policies.Testing
I modified the existing tests of ingress policies (and external netpols) according to the changes.
Checklist