Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support applying intents to API server "kubernetes" service, even when it doesn't have a pod #328

Merged
merged 4 commits into from
Jan 7, 2024

Conversation

NetanelBollag
Copy link
Contributor

@NetanelBollag NetanelBollag commented Jan 4, 2024

Description

It's a common implementation to have the control plane API server service with no pod, just an endpoint mapped to a server outside of the cluster network. Since egress enforcement requires explicitly enabling access to the API server, this PR allow the user to declare intents to the service in the format: svc:kubernetes.default, and the result will be an egress network policy to the server IP address and port.

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

Egress network policy is an experimental feature, full documentation will be available on official release.

  • I have added documentation for new/changed functionality in this PR and in github.com/otterize/docs

Copy link
Contributor

@amitlicht amitlicht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see one comment inside

@NetanelBollag NetanelBollag enabled auto-merge (squash) January 7, 2024 11:30
@NetanelBollag NetanelBollag merged commit 0a8a203 into main Jan 7, 2024
9 checks passed
@NetanelBollag NetanelBollag deleted the netanelb/support-intents-to-k8s-api-server branch January 7, 2024 12:39
@github-actions github-actions bot locked and limited conversation to collaborators Jan 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants