Support specifying kind in ClientIntents (both for spec.service and spec.calls.call), ProtectedServices, and KafkaServerConfigs
#409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ormattedIdentity` to avoid code duplications
omris94
changed the title
clientIntentskind in ClientIntents (both for the calls and the service), ProtectedServices, and KafkaServerConfigs
omris94
changed the title
kind in ClientIntents (both for the calls and the service), ProtectedServices, and KafkaServerConfigskind in ClientIntents (for calls and for service specification), ProtectedServices, and KafkaServerConfigs
omris94
changed the title
kind in ClientIntents (for calls and for service specification), ProtectedServices, and KafkaServerConfigskind in ClientIntents (both for spec.service and spec.calls.call), ProtectedServices, and KafkaServerConfigs
orishoshan
reviewed
May 21, 2024
Co-authored-by: Ori Shoshan <ori@otterize.com>
orishoshan
approved these changes
May 22, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support specifying
kindinClientIntents(both for the calls and the service),ProtectedServices, andKafkaServerConfigs. By doing so we are solving an ambiguity problem caused by the service identity resolution mechanism we used (service identity == pod owner name and namespace).This change is the first of a series of modifications aimed at improving and simplifying the use and comprehensibility of Otterize's IBAC.
Testing
Describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.
Please include any manual steps for testing end-to-end or functionality not covered by unit/integration tests.
Also include details of the environment this PR was developed in (language/platform/browser version).
Checklist
There is no need for documentation at this point.