Use new error telemetry API #435
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| func (s *ErrorSender) SendSync(errs []*telemetriesgql.Error) error { | ||
| ctxTimeout, cancel := context.WithTimeout(context.Background(), 30*time.Second) |
There was a problem hiding this comment.
Suggested change
| ctxTimeout, cancel := context.WithTimeout(context.Background(), 30*time.Second) | |
| clientTimeout := viper.GetDuration(telemetriesconfig.TimeoutKey) | |
| ctxTimeout, cancel := context.WithTimeout(context.Background(), clientTimeout) |
| return graphql.NewClient(apiAddress, clientWithTimeout) | ||
| } | ||
|
|
||
| func (s *ErrorSender) SendSync(errs []*telemetriesgql.Error) error { |
There was a problem hiding this comment.
Guess we should also check here
Suggested change
| func (s *ErrorSender) SendSync(errs []*telemetriesgql.Error) error { | |
| func (s *ErrorSender) SendSync(errs []*telemetriesgql.Error) error { | |
| if !s.enabled { | |
| return nil | |
| } | |
| @@ -7,6 +7,7 @@ import ( | |||
|
|
|||
| const ( | |||
| TelemetryAPIAddressKey = "telemetry-address" | |||
| TelemetryAPIAddressDefault = "http://localhost:8081/api/telemetry/query" | |||
There was a problem hiding this comment.
Doesn't this make deployments without helm charts disabled by default? Should be app.otterize.com by default but to change it on init to localhost if version == "0-local" so locally build images won't trigger production
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the dependency on the Bugsnag SDK for error telemetry and uses a GraphQL-based API to report errors, similar to the usage telemetry API.