New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error reporting missing stack trace due to using fmt.Errorf rather than errors.Errorf #450

Merged

amitlicht merged 1 commit into main from amitlicht/replace_fmt_err_with_errors

Jul 2, 2024

Contributor

amitlicht commented Jul 2, 2024

Description

Replace usage of fmt.Errorf with our internal errors.Errorf implementation, to ensure that errors are reported with full stack traces.


          Replace fmt.Errorf with errors.Errorf for proper error stack reporting

85c77df

amitlicht marked this pull request as ready for review

July 2, 2024 06:36

amitlicht requested a review from orishoshan

July 2, 2024 06:36

orishoshan approved these changes

View reviewed changes

amitlicht merged commit ad0a9d8 into main

15 checks passed

amitlicht deleted the amitlicht/replace_fmt_err_with_errors branch

July 2, 2024 06:50

github-actions bot locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.