Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add separator-option in paramstore post processor #1210

Conversation

ewoelfel
Copy link
Contributor

@ewoelfel ewoelfel commented Feb 9, 2024

Hi,

we do have parameters that are named the following way:
/some/service/subSection/config

The existing setup requires application-properties to be subSection/config which do not represent the standard way of accessing properties with structures.

I suggest introducing a separator option helping to resolve this issue.
This way our example would result in subSection.config

Thanks

@ewoelfel ewoelfel force-pushed the add-seperator-option-in-paramstore-post-processor branch from 61be58d to 23b2d54 Compare February 9, 2024 22:36
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d9d447e) 72.55% compared to head (8437848) 72.58%.
Report is 1 commits behind head on main.

❗ Current head 8437848 differs from pull request most recent head 23b2d54. Consider uploading reports for the commit 23b2d54 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1210      +/-   ##
============================================
+ Coverage     72.55%   72.58%   +0.03%     
- Complexity     1221     1224       +3     
============================================
  Files           198      198              
  Lines          4463     4469       +6     
  Branches        394      395       +1     
============================================
+ Hits           3238     3244       +6     
  Misses         1000     1000              
  Partials        225      225              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frankbregulla1111 frankbregulla1111 merged commit 30118bf into otto-de:main Feb 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants