Merge pull request #85 from ottogroup/feature/resolve-dotted-name-mod…

…ules resolve_dotted_names can now resolve module names, such as 'pickle'
ottogroup · May 29, 2018 · 8fb6b3d · 8fb6b3d
2 parents 1909827 + 9a5bfb3
commit 8fb6b3d
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/palladium/tests/test_util.py b/palladium/tests/test_util.py
@@ -24,6 +24,9 @@ def test_with_dots(self, resolve_dotted_name):
         assert (resolve_dotted_name(dotted) is
                 TestResolveDottedName)
 
+    def test_module(self, resolve_dotted_name):
+        resolve_dotted_name('threading') is threading
+
 
 def test_args_from_config(config):
     from palladium.util import args_from_config

diff --git a/palladium/util.py b/palladium/util.py
@@ -35,12 +35,15 @@
 def resolve_dotted_name(dotted_name):
     if ':' in dotted_name:
         module, name = dotted_name.split(':')
-    else:
+    elif '.' in dotted_name:
         module, name = dotted_name.rsplit('.', 1)
+    else:
+        module, name = dotted_name, None
 
     attr = import_module(module)
-    for name in name.split('.'):
-        attr = getattr(attr, name)
+    if name:
+        for name in name.split('.'):
+            attr = getattr(attr, name)
 
     return attr