Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce AWS S3 persister #118

Merged
merged 3 commits into from
Sep 30, 2019
Merged

Conversation

ottonemo
Copy link
Contributor

This persister allows storing and loading models to and from AWS S3
buckets using s3fs to abstract the necessary API calls.

As discussed in #110 (comment) I have added the dependencies as extra dependencies and the imports are handled in the S3IO class.

This persister allows storing and loading models to and from AWS S3
buckets using s3fs to abstract the necessary API calls.
@ottonemo
Copy link
Contributor Author

Tests are currently failing since the moto library (a library to mock boto calls) is not installed by travis. Should we skip the tests or should we install these dependencies?

@alattner
Copy link
Contributor

Thanks for the enhancement! Please add the dependencies to .travis.yml such that we get it tested in the CI pipeline.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 99.785% when pulling 5901fe9 on ottonemo:feature/s3-persister into 52d0aed on ottogroup:master.

@alattner alattner merged commit 20e369b into ottogroup:master Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants