Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script for creating docker images. Refactor handling. #2

Merged
merged 7 commits into from
Apr 28, 2015

Conversation

dnouri
Copy link
Collaborator

@dnouri dnouri commented Apr 24, 2015

  • Refactor docker base image and update docs.
  • Upload base image to docker hub.
  • Refactor docker add app image and update docs.
  • Allow docker app image to be created through a more convenient command-line script.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 6c23147 on GBIPMMF-190 into 6805789 on develop.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 93a9793 on GBIPMMF-190 into 6805789 on develop.

The biggest challenge here is to keep docs up to date.  Also not sure if the
palladium_app_image directory still needs to exist.
@dnouri
Copy link
Collaborator Author

dnouri commented Apr 24, 2015

@alattner Could you please proof-read the docs changes in the last commit? There's also another comment in there.

Also, do we already have a Docker hub account? Assume not, in which case I'll probably just create ottogroup?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 77fd7ed on GBIPMMF-190 into 6805789 on develop.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 57db018 on GBIPMMF-190 into 6805789 on develop.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 37c01b2 on GBIPMMF-190 into 6805789 on develop.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 5399536 on GBIPMMF-190 into 6805789 on develop.

@dnouri dnouri changed the title [WIP] Add script for creating docker images. Refactor handling. Add script for creating docker images. Refactor handling. Apr 28, 2015
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 09ba3ec on GBIPMMF-190 into 6805789 on develop.

alattner added a commit that referenced this pull request Apr 28, 2015
Add script for creating docker images. Refactor handling.
@alattner alattner merged commit 551d2d5 into develop Apr 28, 2015
@alattner alattner deleted the GBIPMMF-190 branch April 28, 2015 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants