Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jq report output for without jq property. #204

Closed
chrisparnin opened this issue Feb 13, 2020 · 1 comment
Closed

Remove jq report output for without jq property. #204

chrisparnin opened this issue Feb 13, 2020 · 1 comment
Assignees

Comments

@chrisparnin
Copy link
Contributor

The following checks should not include jq output, given no jq is provided:

	contains check
		Checking if you have MSDOS style newlines in your bash scripts. Fix with dos2unix
	    ✔   [...run-ansible.sh] jq query: undefined does not contain: [\r] status: true message: NA
	contains check
	    ✔   [...config.json] jq query: undefined  contains: ["DriverName": "mysql"] status: true message: NA

Given these checks:

      - contains:
          comment: Checking if you have MSDOS style newlines in your bash scripts. Fix with dos2unix
          string: "\r"
          expect: false
          file: /bakerx/cm/run-ansible.sh
      - contains:
         file: /opt/mattermost/config/config.json
         string: '"DriverName": "mysql"'
@chrisparnin chrisparnin changed the title Remove jq report output for non-jq output Remove jq report output for without jq property. Feb 13, 2020
@ssmirr
Copy link
Contributor

ssmirr commented Feb 13, 2020

fixed:

contains check
    ✖   [...config.json] jq query: .dependencies.chalk  contains: [^3.0.1] status: false message: NA
contains check
    ✖   [...config.json] contains: ["homepage": "https://github.com/ottomatica/opunit#readme",] status: false message: Error: file doesn't exist

ssmirr added a commit that referenced this issue Feb 13, 2020
@ssmirr ssmirr closed this as completed Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants