Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Availability check for Vagrant connector #32

Closed
ssmirr opened this issue Nov 19, 2018 · 1 comment
Closed

Availability check for Vagrant connector #32

ssmirr opened this issue Nov 19, 2018 · 1 comment
Projects

Comments

@ssmirr
Copy link
Contributor

ssmirr commented Nov 19, 2018

At the moment Vagrant connector is not able to run availability checks on VMs because of missing getContainerIp(...) function:

let ip = await this.connector.getContainerIp(context);

This function should just return the ip address for the VM, for an example see this function in Baker connector:

async getContainerIp(context)
{
let doc = await this.getOrLoadBakerYaml(context);
if( doc.vm && doc.vm.ip)
{
return doc.vm.ip;
}
throw new Error(`No ip defined in baker file in ${context.bakerPath}`);
}

I think the best way to get the IP of the Vagrant VM is to parse Vagrantfile:

config.vm.network "private_network", ip: "192.168.33.10"

In addition to adding getContainerIP(), updating setup() and tearDown() are needed.

@ssmirr ssmirr added this to To do in 0.2.0 via automation Nov 19, 2018
ssmirr pushed a commit that referenced this issue Nov 29, 2018
* Implemented getContainerIP for #32
* Successfully retrieve container IP for vagrant connector for #32
* Implemented setup() for vagrant connector #32
@ssmirr
Copy link
Contributor Author

ssmirr commented Nov 30, 2018

For availability check to fully work for Vagrant and Ssh connectors, a tearDown() is needed. Job of this function is stop the server after availability check's work is done. I'm closing this issue and creating a new one for tearDown() to include more details.

@ssmirr ssmirr closed this as completed Nov 30, 2018
0.2.0 automation moved this from To do to Done Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
0.2.0
  
Done
Development

No branches or pull requests

1 participant