Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setup.py --> pyproject.toml #360

Merged
merged 2 commits into from
Mar 8, 2023
Merged

setup.py --> pyproject.toml #360

merged 2 commits into from
Mar 8, 2023

Conversation

knaaptime
Copy link
Member

  • swap to platformdirs
  • use pyproject

@knaaptime knaaptime requested a review from jGaboardi March 8, 2023 00:49
@jGaboardi
Copy link
Member

You'll always have to update geosnap/__init__.py when swapping out versioneer for setup tools_scm. See example in spopt/__init__.py.

@jGaboardi
Copy link
Member

Are theCI failures expected?

@knaaptime
Copy link
Member Author

yeah i think so. The 3.10s are all known and the windows machines are just running outta memory cause ive sent too many prs today

jGaboardi
jGaboardi approved these changes Mar 8, 2023
View reviewed changes
Copy link
Member

@jGaboardi jGaboardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@knaaptime knaaptime merged commit 6d639ef into oturns:main Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jGaboardi jGaboardi jGaboardi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@knaaptime @jGaboardi