Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix archive detection #125

Merged
merged 5 commits into from
Oct 31, 2021
Merged

Fix archive detection #125

merged 5 commits into from
Oct 31, 2021

Conversation

SpyrosRoum
Copy link
Contributor

This introduces an is_archive_format method on CompressionFormat and uses it were appropriate

This closes #112

@SpyrosRoum
Copy link
Contributor Author

Okay, I believe up to this everything is good, tests will be complaining though because it's trying to compress to tar.zst but zst is an archive format and we don't allow that kind of thing currently. Is this correct, can I just remove these cases from the tests?

@marcospb19
Copy link
Member

Wait, is zst really an archive format?

@SpyrosRoum
Copy link
Contributor Author

Hmm no, I think I'm just being dumb.
I run zstd file1 file2 and it produced two .zst files.. I run the same command earlier and noticed only one of them without looking too closely

@SpyrosRoum SpyrosRoum marked this pull request as ready for review October 21, 2021 23:35
@marcospb19
Copy link
Member

hahahaha lol

@boozec boozec mentioned this pull request Oct 25, 2021
Merged
@marcospb19 marcospb19 merged commit 77873cd into ouch-org:master Oct 31, 2021
@marcospb19 marcospb19 added the hacktoberfest-accepted Tag PR as accepted for the hacktoberfest event label Oct 31, 2021
@marcospb19
Copy link
Member

Nice PR, sorry for the late merge, I took some time from ouch but will try to come back now.

@SpyrosRoum SpyrosRoum deleted the fix-archive-format-detection branch November 2, 2021 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcospb19 marcospb19 marcospb19 left review comments

@figsoda figsoda figsoda left review comments

Assignees
No one assigned
Labels
hacktoberfest-accepted Tag PR as accepted for the hacktoberfest event
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong archive format detection patterns
3 participants
@SpyrosRoum @marcospb19 @figsoda