Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewrite ci #135

Merged
merged 1 commit into from Nov 1, 2021
Merged

rewrite ci #135

merged 1 commit into from Nov 1, 2021

Conversation

figsoda
Copy link
Member

@figsoda figsoda commented Nov 1, 2021

  • builds and tests in debug mode with stable
  • builds in release mode and uploads stripped binaries with nightly
  • uploads completions and man page on x86_64-unknown-linux-musl
  • checks with clippy and rustfmt

platforms:

  • x86_64-apple-darwin
  • x86_64-pc-windows-msvc
  • x86_64-unknown-linux-gnu
  • x86_64-unknown-linux-musl

@marcospb19
Copy link
Member

builds in release mode and uploads stripped binaries with nightly

Maybe we should upload binaries compiled with stable Rust while we don't use any proper Rust nightly feature, just the rustfmt unstable features.

This way CI can also detect if we are using nightly features.

Not that I want to block nightly, it has nice features but we would only like to depend on it if given a big reason.

@figsoda
Copy link
Member Author

figsoda commented Nov 1, 2021

nightly rust supports stripping so we don't have to figure out how to strip binaries on different platforms

@marcospb19
Copy link
Member

Ok, that's very useful 😄 merging!

@marcospb19 marcospb19 merged commit fa07b55 into ouch-org:master Nov 1, 2021
@figsoda figsoda deleted the rewrite-ci branch November 1, 2021 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants