refac: use BStr to display possibly non-UTF8 byte sequences #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrmiguel
force-pushed
the
bstr-path-display
branch
from
ccae36b
to
2caeb10
Compare
figsoda
reviewed
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses
bstr::BStrto display Paths in the same way thatutils::to_utfdoes (i.e. without quotes and using the Unicode replacement character) but with less cost: without std's UTF-8 check and without heap allocations when the sequence is non-UTF8to_utfis still used in some places but I aim to remove that in another PR