Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement --fast and --slow #374

Merged
merged 4 commits into from
Mar 20, 2023
Merged

implement --fast and --slow #374

merged 4 commits into from
Mar 20, 2023

Conversation

figsoda
Copy link
Member

@figsoda figsoda commented Mar 19, 2023 •
edited
Loading

closes #373

should --fast be 1 instead of 0?

@figsoda figsoda mentioned this pull request Mar 19, 2023
Closed
marcospb19
marcospb19 requested changes Mar 19, 2023
View reviewed changes
src/cli/args.rs Show resolved Hide resolved
src/commands/mod.rs Outdated Show resolved Hide resolved
@marcospb19
Copy link
Member

marcospb19 commented Mar 19, 2023 •
edited
Loading

should --fast be 1 instead of 0

oh yeah, I belive so, people will expect --fast to still do some compression!

I'll review each format just to be sure that 1 means what we're expecting.

otherwise I think --fast would be kinda useless

@figsoda figsoda merged commit 2b142ff into ouch-org:main Mar 20, 2023
@figsoda figsoda deleted the fast branch March 20, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcospb19 marcospb19 marcospb19 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add flags for slowest and fastest compression levels
2 participants
@figsoda @marcospb19