Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding FinalError, using in crate::Error Display #39

Merged
merged 1 commit into from
May 28, 2021
Merged

Adding FinalError, using in crate::Error Display #39

merged 1 commit into from
May 28, 2021

Conversation

marcospb19
Copy link
Member

@marcospb19 marcospb19 commented May 28, 2021 •
edited
Loading

Helps us add nice and consistently formatted error messages

Fixes #33

@marcospb19
Adding FinalError, using in crate::Error Display
51a88be 
Helps us add nice and consistently formatted error messages
@marcospb19 marcospb19 requested a review from vrmiguel May 28, 2021 19:56
@marcospb19
Copy link
Member Author

Requires polishment.

Current example:
image

@vrmiguel
Copy link
Member

🎉🎉🎉🎉

@vrmiguel vrmiguel merged commit 62a4fe6 into master May 28, 2021
@marcospb19 marcospb19 deleted the error-treatment-display-struct branch October 14, 2021 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrmiguel vrmiguel vrmiguel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change Display implementation of crate::Error to an more structured FinalUserError
2 participants
@marcospb19 @vrmiguel