Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow compression of empty folders #57

Merged
merged 4 commits into from
Oct 2, 2021
Merged

Allow compression of empty folders #57

merged 4 commits into from
Oct 2, 2021

Conversation

GabrielSimonetto
Copy link
Collaborator

@GabrielSimonetto GabrielSimonetto commented Oct 2, 2021 •
edited
Loading

Solves #41

  • - Create failing test
  • - Actually fix stuff - for zip
  • - Actually fix stuff - for tar

@GabrielSimonetto GabrielSimonetto changed the title Create failing test Allow compression of empty folders Oct 2, 2021
@GabrielSimonetto GabrielSimonetto marked this pull request as ready for review October 2, 2021 20:16
@GabrielSimonetto
Copy link
Collaborator Author

GabrielSimonetto commented Oct 2, 2021 •
edited
Loading

I solved zip for now, I can keep working on the tar solution but would you like to do this on a single PR or on 2 separated PR's?

p.s.: welp, tar was way easier

@marcospb19
Copy link
Member

Nice!

@marcospb19 marcospb19 merged commit 402f33b into ouch-org:master Oct 2, 2021
@marcospb19 marcospb19 added the hacktoberfest-accepted Tag PR as accepted for the hacktoberfest event label Oct 3, 2021
@marcospb19 marcospb19 mentioned this pull request Oct 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
hacktoberfest-accepted Tag PR as accepted for the hacktoberfest event
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@GabrielSimonetto @marcospb19