Check if a folder is being compressed to a non-archive format #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrmiguel
added
wip
Comment on lines
+156
to
+161
| Error::UnknownExtensionError(_) => todo!(), | ||
| Error::AlreadyExists => todo!(), | ||
| Error::InvalidZipArchive(_) => todo!(), | ||
| Error::PermissionDenied => todo!(), | ||
| Error::UnsupportedZipArchive(_) => todo!(), | ||
| Error::Custom { reason } => reason.clone(), |
GabrielSimonetto
approved these changes
Oct 7, 2021
There was a problem hiding this comment.
Nice
$ cargo run c test_dirs/ t.bz
Finished dev [unoptimized + debuginfo] target(s) in 0.02s
Running `target/debug/ouch c test_dirs/ t.bz`
[ERROR] Cannot compress to 't.bz'.
- You are trying to compress multiple files.
- The compression format '.bz' cannot receive multiple files.
- The only supported formats that archive files into an archive are .tar and .zip.
hint: Try inserting '.tar' or '.zip' before '.bz'.
hint: From: t.bz
hint: To : t.tar.bz
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #78
The previous check already worked well when more than a path was supplied to a non-archive method. However, passing a single directory trips this check and results into a panic. This PR aims to solve that.