Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension: add support for tgz #85

Merged
merged 2 commits into from
Oct 14, 2021
Merged

Extension: add support for tgz #85

merged 2 commits into from
Oct 14, 2021

Conversation

figsoda
Copy link
Member

@figsoda figsoda commented Oct 13, 2021

Fixes #47

@marcospb19
Copy link
Member

Thanks for opening a pull request! We really appreciate your help.

src/extension.rs Outdated Show resolved Hide resolved
src/extension.rs Outdated Show resolved Hide resolved
@figsoda
Copy link
Member Author

figsoda commented Oct 13, 2021

I did a force push and added a new Tgz format that emulates [Gzip, Tar] and should give the correct error messages

@marcospb19
Copy link
Member

If you don't mind, I did some small changes (added a comment here and created an extra variable there).

Was trying to remove some of the code repetition in the compress_files, but I realized it was not possible, but I committed the small changes anyways.

@marcospb19 marcospb19 merged commit f923423 into ouch-org:master Oct 14, 2021
@figsoda figsoda deleted the tgz branch October 14, 2021 19:56
@marcospb19 marcospb19 added the hacktoberfest-accepted Tag PR as accepted for the hacktoberfest event label Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Tag PR as accepted for the hacktoberfest event
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support .tgz
3 participants