cause list-all argument to give perl-build versions in opposite order
#3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ASDF `latest` arg grabs *last* entry from `list-all` command, meaning that the list of available Perl definitions should be printed in the reverse of order provided by perl-build.
oeuftete
reviewed
May 13, 2021
bin/list-all
Outdated
| @@ -4,7 +4,7 @@ source "$(dirname "$0")/utils.sh" | |||
|
|
|||
| list_all() { | |||
| install_or_update_perl_build | |||
| $(perl_build_path) --definitions | tr '\n' ' ' | |||
| $(perl_build_path) --definitions | tr '\n' ' ' | tail -r | |||
There was a problem hiding this comment.
tail -r isn't portable (only in BSD tail), and this pipe needs to come before the newlines are translated, I believe?
For example, if tac is available, this does what's intended:
$(perl_build_path) --definitions | tac | tr '\n' ' '
There was a problem hiding this comment.
Yes, that's a good point. tac would be preferable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ASDF
latestarg grabs last entry fromlist-allcommand, meaning that the list of available Perl definitions should be printed in the reverse of the order provided by perl-build (as in, the latest version should come last).